Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[protoc-gen-grpc-web] Invalid output from proto files without package specified #184

Closed
zaucy opened this issue May 14, 2018 · 0 comments · Fixed by #185
Closed

[protoc-gen-grpc-web] Invalid output from proto files without package specified #184

zaucy opened this issue May 14, 2018 · 0 comments · Fixed by #185

Comments

@zaucy
Copy link
Contributor

zaucy commented May 14, 2018

A proto file that does not specify a package would result in invalid js files that contain similar to this:

proto..TestServiceClient = /* ... */
@zaucy zaucy mentioned this issue May 14, 2018
Merged
@zaucy zaucy changed the title [protoc-gen-web-grpc] Invalid output from proto files without package specified [protoc-gen-grpc-web] Invalid output from proto files without package specified May 14, 2018
@stanley-cheung stanley-cheung mentioned this issue Oct 6, 2018
Merged
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this issue Sep 4, 2020
@nathanb21 @MarcusLongmuir
Prevent fetch.pump recursively returning promises (grpc#184)
fb9ccd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for proto files without packages zaucy/grpc-web
1 participant
@zaucy