Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for proto files without packages #185

Merged
merged 1 commit into from
May 15, 2018
Merged

Support for proto files without packages #185

merged 1 commit into from
May 15, 2018

Conversation

zaucy
Copy link
Contributor

@zaucy zaucy commented May 14, 2018

This fixes #184

@stanley-cheung
Copy link
Collaborator

ok to test

@stanley-cheung stanley-cheung merged commit e9cdfe0 into grpc:master May 15, 2018
@stanley-cheung
Copy link
Collaborator

Thanks for your contribution!

@zaucy zaucy deleted the no-package-fix branch May 16, 2018 08:14
loyalpartner pushed a commit to loyalpartner/grpc-web that referenced this pull request Sep 4, 2020
@MarcusLongmuir
Added github.com/gorilla/websocket to Gopkg.toml (grpc#185)
bb7e708
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley-cheung stanley-cheung stanley-cheung approved these changes

Assignees
No one assigned
Labels
release notes: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[protoc-gen-grpc-web] Invalid output from proto files without package specified
2 participants
@zaucy @stanley-cheung