Allow GrpcWebStreamParser to accept Uint8Array #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var pos = 0; | ||
|
|
||
| if (input instanceof Uint8Array || input instanceof Array) { | ||
| inputBytes = input |
There was a problem hiding this comment.
nit: missing semicolon. doesn't pass closure lint checks.
| if (input instanceof Uint8Array || input instanceof Array) { | ||
| inputBytes = input | ||
| } else { | ||
| inputBytes = new Uint8Array(input) |
There was a problem hiding this comment.
nit: missing semicolon. doesn't pass closure lint checks
| * @throws {!Error} Throws an error message if the input is invalid. | ||
| * @override |
There was a problem hiding this comment.
Sorry another issue: apparently you need @override here because now the spec differs
|
@stanley-cheung do you think you can merge this in and release? |
|
Thanks, all internal tests passed. |
stanley-cheung
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the following: #710
Suggested by: #683 (comment)