Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use @grpc/grpc-js node package, and update helloworld example #852

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

stanley-cheung
Copy link
Collaborator

@stanley-cheung stanley-cheung commented Jun 11, 2020

With the 1.0 release of @grpc/grpc-js and the announcement that the original grpc node package will not receive new features, let's update our usage to the @grpc/grpc-js package.

In the process, I made some cleanups to the helloworld example.

  • The helloworld example server.js needs to use bindAsync instead of bind
  • I removed the deadline exceeded example to keep the helloworld example simple. (Technically, even the streaming example for helloworld example shouldn't be there. We are using a custom copy of the helloworld.proto here, which arguably, we should not.)
  • I removed the need for a envoy.Dockerfile. We can just run the standard Envoy image and pass in our custom envoy.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant