Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helloworld example docker command #854

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Conversation

kohashi
Copy link
Contributor

@kohashi kohashi commented Jun 15, 2020

@stanley-cheung 's update is really great!
#852

But the example Docker command didn't have port mapping, therefore it's not work in my environment (and probably anyone else's).

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 15, 2020

CLA Check
The committers are authorized under a signed CLA.

@stanley-cheung
Copy link
Collaborator

stanley-cheung commented Jun 15, 2020

I distinctly remember that running with --network=host on my linux machine gives a warning that those -p parameters will be ignored. And running with just --network=host on my linux machine was just fine. So I am inclined to leave it at that. Perhaps we just fix Line 305 (which is in a quote block, more like an "in case it doesn't work .... do this instead"), but leave L297 alone? Thanks for understanding.

@kohashi
Copy link
Contributor Author

kohashi commented Jun 16, 2020

Thanks for the message. I hadn't tried it on a linux machine, but I needed the -p parameters in my Mac environment. I update commit (fix only L305).

Copy link
Collaborator

@stanley-cheung stanley-cheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@stanley-cheung stanley-cheung merged commit 8c96b8c into grpc:master Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants