Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Build] Removed gRPC_PROTOBUF_PACKAGE_TYPE, supporting config only (#…
…32988) `FindProtobuf` isn't working as Protobuf began to use Abseil so gRPC is now using `CONFIG` mode for protobuf module (Context: https://gitlab.kitware.com/cmake/cmake/-/issues/24321)
- Loading branch information
Showing
7 changed files
with
2 additions
and
16 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
303e568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@veblush This has broken finding of
protobuf
.P. S. Unsurprisingly so, since
protobuf
does not install *config.cmake at all, at least when not built with CMake: https://ports.macports.org/port/protobuf3-cpp/detailsSpecifying include and lib dirs does not seem to work either.
Earlier versions of
grpc
were findingprotobuf
with no issues.303e568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have a workaround. As is I might patch in a revert of this commit until there is a resolution.
303e568
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Allen-Webb We have moved to CMake in macports/macports-ports@2660da8 – but it is still desirable, I think, not to force everyone use CMake build system with
protobuf
.