Skip to content

Commit

Permalink
Mandate static string for host and method passed to grpc_channel_regi…
Browse files Browse the repository at this point in the history
…ster_call

This is for the gRFC being prepared.

Bump the major version to 1.25.
  • Loading branch information
soheilhy committed Aug 9, 2019
1 parent aa7f4ba commit 5cd0511
Show file tree
Hide file tree
Showing 34 changed files with 41 additions and 39 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
cmake_minimum_required(VERSION 3.5.1)

set(PACKAGE_NAME "grpc")
set(PACKAGE_VERSION "1.24.0-dev")
set(PACKAGE_VERSION "1.25.0-dev")
set(PACKAGE_STRING "${PACKAGE_NAME} ${PACKAGE_VERSION}")
set(PACKAGE_TARNAME "${PACKAGE_NAME}-${PACKAGE_VERSION}")
set(PACKAGE_BUGREPORT "https://github.com/grpc/grpc/issues/")
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -455,8 +455,8 @@ Q = @
endif

CORE_VERSION = 7.0.0
CPP_VERSION = 1.24.0-dev
CSHARP_VERSION = 2.24.0-dev
CPP_VERSION = 1.25.0-dev
CSHARP_VERSION = 2.25.0-dev

CPPFLAGS_NO_ARCH += $(addprefix -I, $(INCLUDES)) $(addprefix -D, $(DEFINES))
CPPFLAGS += $(CPPFLAGS_NO_ARCH) $(ARCH_FLAGS)
Expand Down
2 changes: 1 addition & 1 deletion build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ settings:
core_version: 7.0.0
csharp_major_version: 2
g_stands_for: ganges
version: 1.24.0-dev
version: 1.25.0-dev
filegroups:
- name: alts_tsi
headers:
Expand Down
4 changes: 2 additions & 2 deletions gRPC-C++.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@
Pod::Spec.new do |s|
s.name = 'gRPC-C++'
# TODO (mxyan): use version that match gRPC version when pod is stabilized
# version = '1.24.0-dev'
# version = '1.25.0-dev'
version = '0.0.9-dev'
s.version = version
s.summary = 'gRPC C++ library'
s.homepage = 'https://grpc.io'
s.license = 'Apache License, Version 2.0'
s.authors = { 'The gRPC contributors' => 'grpc-packages@google.com' }

grpc_version = '1.24.0-dev'
grpc_version = '1.25.0-dev'

s.source = {
:git => 'https://github.com/grpc/grpc.git',
Expand Down
2 changes: 1 addition & 1 deletion gRPC-Core.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@

Pod::Spec.new do |s|
s.name = 'gRPC-Core'
version = '1.24.0-dev'
version = '1.25.0-dev'
s.version = version
s.summary = 'Core cross-platform gRPC library, written in C'
s.homepage = 'https://grpc.io'
Expand Down
2 changes: 1 addition & 1 deletion gRPC-ProtoRPC.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

Pod::Spec.new do |s|
s.name = 'gRPC-ProtoRPC'
version = '1.24.0-dev'
version = '1.25.0-dev'
s.version = version
s.summary = 'RPC library for Protocol Buffers, based on gRPC'
s.homepage = 'https://grpc.io'
Expand Down
2 changes: 1 addition & 1 deletion gRPC-RxLibrary.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@

Pod::Spec.new do |s|
s.name = 'gRPC-RxLibrary'
version = '1.24.0-dev'
version = '1.25.0-dev'
s.version = version
s.summary = 'Reactive Extensions library for iOS/OSX.'
s.homepage = 'https://grpc.io'
Expand Down
2 changes: 1 addition & 1 deletion gRPC.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

Pod::Spec.new do |s|
s.name = 'gRPC'
version = '1.24.0-dev'
version = '1.25.0-dev'
s.version = version
s.summary = 'gRPC client library for iOS/OSX'
s.homepage = 'https://grpc.io'
Expand Down
4 changes: 3 additions & 1 deletion include/grpc/grpc.h
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ GRPCAPI grpc_call* grpc_channel_create_call(
GRPCAPI void grpc_channel_ping(grpc_channel* channel, grpc_completion_queue* cq,
void* tag, void* reserved);

/** Pre-register a method/host pair on a channel. */
/** Pre-register a method/host pair on a channel.
method and host are not owned and must remain alive while the server is
running. */
GRPCAPI void* grpc_channel_register_call(grpc_channel* channel,
const char* method, const char* host,
void* reserved);
Expand Down
4 changes: 2 additions & 2 deletions package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<date>2018-01-19</date>
<time>16:06:07</time>
<version>
<release>1.24.0dev</release>
<api>1.24.0dev</api>
<release>1.25.0dev</release>
<api>1.25.0dev</api>
</version>
<stability>
<release>beta</release>
Expand Down
4 changes: 2 additions & 2 deletions src/core/lib/surface/channel.cc
Original file line number Diff line number Diff line change
Expand Up @@ -417,10 +417,10 @@ void* grpc_channel_register_call(grpc_channel* channel, const char* method,
grpc_core::ExecCtx exec_ctx;

rc->path = grpc_mdelem_from_slices(GRPC_MDSTR_PATH,
grpc_core::ManagedMemorySlice(method));
grpc_core::ExternallyManagedSlice(method));
rc->authority =
host ? grpc_mdelem_from_slices(GRPC_MDSTR_AUTHORITY,
grpc_core::ManagedMemorySlice(host))
grpc_core::ExternallyManagedSlice(host))
: GRPC_MDNULL;
gpr_mu_lock(&channel->registered_call_mu);
rc->next = channel->registered_calls;
Expand Down
2 changes: 1 addition & 1 deletion src/cpp/common/version_cc.cc
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
#include <grpcpp/grpcpp.h>

namespace grpc {
grpc::string Version() { return "1.24.0-dev"; }
grpc::string Version() { return "1.25.0-dev"; }
} // namespace grpc
4 changes: 2 additions & 2 deletions src/csharp/Grpc.Core.Api/VersionInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ public static class VersionInfo
/// <summary>
/// Current <c>AssemblyFileVersion</c> of gRPC C# assemblies
/// </summary>
public const string CurrentAssemblyFileVersion = "2.24.0.0";
public const string CurrentAssemblyFileVersion = "2.25.0.0";

/// <summary>
/// Current version of gRPC C#
/// </summary>
public const string CurrentVersion = "2.24.0-dev";
public const string CurrentVersion = "2.25.0-dev";
}
}
2 changes: 1 addition & 1 deletion src/csharp/build/dependencies.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<!-- This file is generated -->
<Project>
<PropertyGroup>
<GrpcCsharpVersion>2.24.0-dev</GrpcCsharpVersion>
<GrpcCsharpVersion>2.25.0-dev</GrpcCsharpVersion>
<GoogleProtobufVersion>3.8.0</GoogleProtobufVersion>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion src/csharp/build_unitypackage.bat
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
@rem limitations under the License.

@rem Current package versions
set VERSION=2.24.0-dev
set VERSION=2.25.0-dev

@rem Adjust the location of nuget.exe
set NUGET=C:\nuget\nuget.exe
Expand Down
2 changes: 1 addition & 1 deletion src/objective-c/!ProtoCompiler-gRPCCppPlugin.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Pod::Spec.new do |s|
# exclamation mark ensures that other "regular" pods will be able to find it as it'll be installed
# before them.
s.name = '!ProtoCompiler-gRPCCppPlugin'
v = '1.24.0-dev'
v = '1.25.0-dev'
s.version = v
s.summary = 'The gRPC ProtoC plugin generates C++ files from .proto services.'
s.description = <<-DESC
Expand Down
2 changes: 1 addition & 1 deletion src/objective-c/!ProtoCompiler-gRPCPlugin.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Pod::Spec.new do |s|
# exclamation mark ensures that other "regular" pods will be able to find it as it'll be installed
# before them.
s.name = '!ProtoCompiler-gRPCPlugin'
v = '1.24.0-dev'
v = '1.25.0-dev'
s.version = v
s.summary = 'The gRPC ProtoC plugin generates Objective-C files from .proto services.'
s.description = <<-DESC
Expand Down
2 changes: 1 addition & 1 deletion src/objective-c/GRPCClient/private/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,4 @@
// instead. This file can be regenerated from the template by running
// `tools/buildgen/generate_projects.sh`.

#define GRPC_OBJC_VERSION_STRING @"1.24.0-dev"
#define GRPC_OBJC_VERSION_STRING @"1.25.0-dev"
2 changes: 1 addition & 1 deletion src/objective-c/tests/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@
// instead. This file can be regenerated from the template by running
// `tools/buildgen/generate_projects.sh`.

#define GRPC_OBJC_VERSION_STRING @"1.24.0-dev"
#define GRPC_OBJC_VERSION_STRING @"1.25.0-dev"
#define GRPC_C_VERSION_STRING @"7.0.0"
2 changes: 1 addition & 1 deletion src/php/composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "grpc/grpc-dev",
"description": "gRPC library for PHP - for Developement use only",
"license": "Apache-2.0",
"version": "1.24.0",
"version": "1.25.0",
"require": {
"php": ">=5.5.0",
"google/protobuf": "^v3.3.0"
Expand Down
2 changes: 1 addition & 1 deletion src/php/ext/grpc/version.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@
#ifndef VERSION_H
#define VERSION_H

#define PHP_GRPC_VERSION "1.24.0dev"
#define PHP_GRPC_VERSION "1.25.0dev"

#endif /* VERSION_H */
2 changes: 1 addition & 1 deletion src/python/grpcio/grpc/_grpcio_metadata.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio/grpc/_grpcio_metadata.py.template`!!!

__version__ = """1.24.0.dev0"""
__version__ = """1.25.0.dev0"""
2 changes: 1 addition & 1 deletion src/python/grpcio/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/python/grpcio_channelz/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio_channelz/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/python/grpcio_health_checking/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio_health_checking/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/python/grpcio_reflection/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio_reflection/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/python/grpcio_status/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio_status/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/python/grpcio_testing/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio_testing/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/python/grpcio_tests/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/src/python/grpcio_tests/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion src/ruby/lib/grpc/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@

# GRPC contains the General RPC module.
module GRPC
VERSION = '1.24.0.dev'
VERSION = '1.25.0.dev'
end
2 changes: 1 addition & 1 deletion src/ruby/tools/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@

module GRPC
module Tools
VERSION = '1.24.0.dev'
VERSION = '1.25.0.dev'
end
end
2 changes: 1 addition & 1 deletion tools/distrib/python/grpcio_tools/grpc_version.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@

# AUTO-GENERATED FROM `$REPO_ROOT/templates/tools/distrib/python/grpcio_tools/grpc_version.py.template`!!!

VERSION = '1.24.0.dev0'
VERSION = '1.25.0.dev0'
2 changes: 1 addition & 1 deletion tools/doxygen/Doxyfile.c++
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ PROJECT_NAME = "GRPC C++"
# could be handy for archiving the generated documentation or if some version
# control system is used.
PROJECT_NUMBER = 1.24.0-dev
PROJECT_NUMBER = 1.25.0-dev
# Using the PROJECT_BRIEF tag one can provide an optional one line description
# for a project that appears at the top of each page and should give viewer a
Expand Down
2 changes: 1 addition & 1 deletion tools/doxygen/Doxyfile.c++.internal
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ PROJECT_NAME = "GRPC C++"
# could be handy for archiving the generated documentation or if some version
# control system is used.

PROJECT_NUMBER = 1.24.0-dev
PROJECT_NUMBER = 1.25.0-dev

# Using the PROJECT_BRIEF tag one can provide an optional one line description
# for a project that appears at the top of each page and should give viewer a
Expand Down

0 comments on commit 5cd0511

Please sign in to comment.