Addressed Vijay's comments, fixed string headers

grpc · Feb 27, 2020 · 88b0d84 · 88b0d84
1 parent 4c5ee10
commit 88b0d84
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 5 deletions.
diff --git a/include/grpc/grpc_security.h b/include/grpc/grpc_security.h
@@ -426,8 +426,7 @@ typedef struct {
       const char** error_details);
 
   /** Implements debug string of the given plugin. This method returns an
-   * allocated string that the caller needs to free using gpr_free()
-   * */
+   * allocated string that the caller needs to free using gpr_free() */
   char* (*debug_string)(void* state);
 
   /** Destroys the plugin state. */

diff --git a/src/core/lib/security/credentials/iam/iam_credentials.h b/src/core/lib/security/credentials/iam/iam_credentials.h
@@ -21,7 +21,7 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <string.h>
+#include <string>
 
 #include "src/core/lib/security/credentials/credentials.h"
 

diff --git a/src/core/lib/security/credentials/jwt/jwt_credentials.cc b/src/core/lib/security/credentials/jwt/jwt_credentials.cc
@@ -21,6 +21,7 @@
 #include "src/core/lib/security/credentials/jwt/jwt_credentials.h"
 
 #include <inttypes.h>
+#include <string.h>
 
 #include "src/core/lib/gprpp/ref_counted.h"
 #include "src/core/lib/gprpp/ref_counted_ptr.h"

diff --git a/src/core/lib/security/credentials/jwt/jwt_credentials.h b/src/core/lib/security/credentials/jwt/jwt_credentials.h
@@ -21,7 +21,7 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <string.h>
+#include <string>
 
 #include <grpc/support/time.h>
 

diff --git a/src/core/lib/security/credentials/oauth2/oauth2_credentials.cc b/src/core/lib/security/credentials/oauth2/oauth2_credentials.cc
@@ -21,6 +21,8 @@
 #include "src/core/lib/json/json.h"
 #include "src/core/lib/security/credentials/oauth2/oauth2_credentials.h"
 
+#include <string.h>
+
 #include <grpc/grpc_security.h>
 #include <grpc/impl/codegen/slice.h>
 #include <grpc/slice.h>

diff --git a/src/core/lib/security/credentials/oauth2/oauth2_credentials.h b/src/core/lib/security/credentials/oauth2/oauth2_credentials.h
@@ -21,7 +21,7 @@
 
 #include <grpc/support/port_platform.h>
 
-#include <string.h>
+#include <string>
 
 #include <grpc/grpc_security.h>
 #include "src/core/lib/json/json.h"