Stop worrying about 1 second deadline as a fatal problem

Also fix reporter
grpc · Jun 8, 2015 · d9c7e7e · d9c7e7e
1 parent 372fd87
commit d9c7e7e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/test/cpp/qps/client_async.cc b/test/cpp/qps/client_async.cc
@@ -236,9 +236,9 @@ class AsyncClient : public Client {
     }
     if ((closed_loop_ || !rpc_deadlines_[thread_idx].empty()) &&
         grpc_time_source::now() > deadline) {
-      // we have missed some 1-second deadline, which is too much
-      gpr_log(GPR_INFO, "Missed an RPC deadline, giving up");
-      return false;
+      // we have missed some 1-second deadline, which is worth noting
+      gpr_log(GPR_INFO, "Missed an RPC deadline");
+      // Don't give up, as there might be some truly heavy tails
     }
     if (got_event) {
       ClientRpcContext* ctx = ClientRpcContext::detag(got_tag);

diff --git a/test/cpp/qps/qps_test_openloop.cc b/test/cpp/qps/qps_test_openloop.cc
@@ -61,7 +61,7 @@ static void RunQPS() {
   client_config.set_load_type(POISSON);
   client_config.mutable_load_params()->
     mutable_poisson()->set_offered_load(10000.0);
-  
+
   ServerConfig server_config;
   server_config.set_server_type(ASYNC_SERVER);
   server_config.set_enable_ssl(false);
@@ -70,7 +70,7 @@ static void RunQPS() {
   const auto result =
       RunScenario(client_config, 1, server_config, 1, WARMUP, BENCHMARK, -2);
 
-  GetReporter()->ReportQPSPerCore(*result, server_config);
+  GetReporter()->ReportQPSPerCore(*result);
   GetReporter()->ReportLatency(*result);
 }