Skip to content

Commit

Permalink
Merge pull request #5227 from murgatroid99/node_documentation_update_…
Browse files Browse the repository at this point in the history
…0.13

Update Node examples and example documentation
  • Loading branch information
hsaliak committed Feb 13, 2016
2 parents 44753c3 + d1b3904 commit e612d41
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 187 deletions.
12 changes: 1 addition & 11 deletions examples/node/README.md
Expand Up @@ -4,14 +4,10 @@ gRPC in 3 minutes (Node.js)
PREREQUISITES
-------------

- `node`: This requires Node 0.10.x or greater.
- [homebrew][] on Mac OS X. This simplifies the installation of the gRPC C core.
- `node`: This requires Node 0.12.x or greater.

INSTALL
-------
- [Install gRPC Node][]

- Install this package's dependencies

```sh
$ cd examples/node
Expand All @@ -35,15 +31,9 @@ TRY IT!
$ node ./greeter_client.js
```

NOTE
----
This directory has a copy of `helloworld.proto` because it currently depends on
some Protocol Buffer 2.0 syntax that is deprecated in Protocol Buffer 3.0.

TUTORIAL
--------
You can find a more detailed tutorial in [gRPC Basics: Node.js][]

[homebrew]:http://brew.sh
[Install gRPC Node]:../../src/node
[gRPC Basics: Node.js]:http://www.grpc.io/docs/tutorials/basic/node.html
2 changes: 1 addition & 1 deletion examples/node/greeter_client.js
Expand Up @@ -31,7 +31,7 @@
*
*/

var PROTO_PATH = __dirname + '/helloworld.proto';
var PROTO_PATH = __dirname + '/../protos/helloworld.proto';

var grpc = require('grpc');
var hello_proto = grpc.load(PROTO_PATH).helloworld;
Expand Down
2 changes: 1 addition & 1 deletion examples/node/greeter_server.js
Expand Up @@ -31,7 +31,7 @@
*
*/

var PROTO_PATH = __dirname + '/helloworld.proto';
var PROTO_PATH = __dirname + '/../protos/helloworld.proto';

var grpc = require('grpc');
var hello_proto = grpc.load(PROTO_PATH).helloworld;
Expand Down
50 changes: 0 additions & 50 deletions examples/node/helloworld.proto

This file was deleted.

2 changes: 1 addition & 1 deletion examples/node/package.json
Expand Up @@ -2,6 +2,6 @@
"name": "grpc-examples",
"version": "0.1.0",
"dependencies": {
"grpc": "0.12.0"
"grpc": "0.13.0"
}
}
120 changes: 0 additions & 120 deletions examples/node/route_guide/route_guide.proto

This file was deleted.

6 changes: 4 additions & 2 deletions examples/node/route_guide/route_guide_client.js
Expand Up @@ -31,15 +31,17 @@
*
*/

var PROTO_PATH = __dirname + '/../../protos/route_guide.proto';

var async = require('async');
var fs = require('fs');
var parseArgs = require('minimist');
var path = require('path');
var _ = require('lodash');
var grpc = require('grpc');
var routeguide = grpc.load(__dirname + '/route_guide.proto').routeguide;
var routeguide = grpc.load(PROTO_PATH).routeguide;
var client = new routeguide.RouteGuide('localhost:50051',
grpc.Credentials.createInsecure());
grpc.credentials.createInsecure());

var COORD_FACTOR = 1e7;

Expand Down
4 changes: 3 additions & 1 deletion examples/node/route_guide/route_guide_server.js
Expand Up @@ -31,12 +31,14 @@
*
*/

var PROTO_PATH = __dirname + '/../../protos/route_guide.proto';

var fs = require('fs');
var parseArgs = require('minimist');
var path = require('path');
var _ = require('lodash');
var grpc = require('grpc');
var routeguide = grpc.load(__dirname + '/route_guide.proto').routeguide;
var routeguide = grpc.load(PROTO_PATH).routeguide;

var COORD_FACTOR = 1e7;

Expand Down

0 comments on commit e612d41

Please sign in to comment.