Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aio] Implement timeout in the __call__ for the asynchronous UnaryUnary callable #19871

Closed
rmariano opened this issue Aug 7, 2019 · 1 comment · Fixed by #20277
Closed

[aio] Implement timeout in the __call__ for the asynchronous UnaryUnary callable #19871

rmariano opened this issue Aug 7, 2019 · 1 comment · Fixed by #20277

Comments

@rmariano
Copy link

rmariano commented Aug 7, 2019

As part of achieving full parity with the synchronous implementation of the unary unary call (#19760).
The new caller must comply with the original signature form the synchronous channel

@rmariano
Copy link
Author

rmariano commented Aug 7, 2019

@gnossen / @lidizheng Could you please add this to the https://github.com/grpc/grpc/projects/16 project, and triage accordingly? Thanks
cc/ @pfreixes

@rmariano rmariano changed the title [aio] Implement timeout in the __call__ for the asynchronous UnaryUnary callable [aio] Implement timeout in the __call__ for the asynchronous UnaryUnary callable Aug 7, 2019
@gnossen gnossen added this to To Do in gRPC Async API via automation Aug 7, 2019
rmariano pushed a commit to rmariano/grpc that referenced this issue Sep 16, 2019
Allow passing the ``timeout`` parameter in the asynchronous version of
the unary_unary call, and use it accordingly.

Maintains the same interface as the synchronous version.

Fixes grpc#19871
rmariano pushed a commit to rmariano/grpc that referenced this issue Sep 17, 2019
Allow passing the ``timeout`` parameter in the asynchronous version of
the unary_unary call, and use it accordingly.

Maintains the same interface as the synchronous version.

Fixes grpc#19871
rmariano pushed a commit to Skyscanner/grpc that referenced this issue Sep 17, 2019
Allow passing the ``timeout`` parameter in the asynchronous version of
the unary_unary call, and use it accordingly.

Maintains the same interface as the synchronous version.

Fixes grpc#19871
@gnossen gnossen moved this from To Do to In progress in gRPC Async API Sep 27, 2019
rmariano pushed a commit to rmariano/grpc that referenced this issue Oct 9, 2019
Allow passing the ``timeout`` parameter to the asynchronous version of
the ``unary_unary`` call, and use it accordingly.

Maintains the same interface as the synchronous version.

Other changes:

    * Remove default parameters from the internal API methods
    * Make keyword-only arguments in the external-facing public API

Create new exception: ``AioRpcError``.

Define the exception in Cython, exposing a similar interface that the
one returned by the synchronous API (``grpc.RpcError``).

Then mix the class with the ``grpc.RpcError``, dynamically: this can
only be done at run-time because it's not possible to use the Cython
class until all Cython code has been compiled, which happens after the
``grpc`` module has been loaded.

The new ``AioRpcError`` exception lives inside the ``experimental``
module.

Fixes grpc#19871
rmariano pushed a commit to rmariano/grpc that referenced this issue Oct 10, 2019
Allow passing the ``timeout`` parameter to the asynchronous version of
the ``unary_unary`` call, and use it accordingly.

Maintains the same interface as the synchronous version.

Other changes:

    * Remove default parameters from the internal API methods
    * Make keyword-only arguments in the external-facing public API

Create new exception: ``AioRpcError``.

Define the exception in Cython, exposing a similar interface that the
one returned by the synchronous API (``grpc.RpcError``).

Then mix the class with the ``grpc.RpcError``, dynamically: this can
only be done at run-time because it's not possible to use the Cython
class until all Cython code has been compiled, which happens after the
``grpc`` module has been loaded.

The new ``AioRpcError`` exception lives inside the ``experimental``
module.

Fixes grpc#19871
gRPC Async API automation moved this from In progress to Done Oct 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Development

Successfully merging a pull request may close this issue.

2 participants