Make grpc++_test target publicly visible #32039
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
requested review from
jtattermusch,
veblush and
gnossen
as code owners
yashykt
added
the
release notes: no
grpc-checks
bot
added
per-call-memory/neutral
per-channel-memory/neutral
bloat/none
labels
ctiller
requested changes
Feb 15, 2023
There was a problem hiding this comment.
I don't think adding a comment would materially affect the maintainability here.
We've made it public internally already - my recommendation would be to remove the annotation from the build system entirely and commit to maintaining this API as part of the public interface, but @markdroth should probably make the final call on that.
|
More than 30 days have passed since label "disposition/requires reporter action" was added. Closing this issue. Please feel free to re-open/create a new issue if this is still relevant. |
|
Is there a suggested way to overcome the visibility issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #31296
I think Craig's concern here was the stability of the APIs. We could potentially add a disclaimer at the very top of all these files that we do not guarantee the stability of these files or this build target. What do y'all think?