New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bundle install
of grpc-1.60.0-x86_64-linux
reports that it is incompatible with Ruby 3.3.0 during GitHub CI
#35396
Comments
Same problem here:
any solution ? |
Inside my project's
Unfortunately, this can cause a download of the full source code of |
Yes same thing here as it download all the source the gem is close to 1 Gb so we cannot deploy our app 😢 |
If you don't want to build from source, you need to stay on Ruby 3.2 until grpc relesses a version where the pre-built native extensions declare compatibility with 3.3. |
+1 — this has added nearly 2GB worth of bloat to our Rails app images and bundler caches on
It seems like the fix for this issue is not working: #33596 The actual shared library is an acceptable size:
But there's 1.7GB of junk in
|
I believe this commit caused the regression from the original fix for #33596: 36af323
|
The bloat when building from source is probably a separate issue to just actully having prebuilt binaries for 3.3. Maybe best to open a dedicated issue so it isn't lost? |
@chadlwilson Given the couple other comments complaining about the surprise bloat when building from source, I figured I'd at least add my findings here, but you're probably right. I'll file a separate ticket when I have a minute to fill out the issue template. |
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628 (cherry picked from commit 43d2b28)
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628
…3.3 support (#35399)" (#35614) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes #35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes #35399 PiperOrigin-RevId: 599200628 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Co-authored-by: Chad Wilson <chadw@thoughtworks.com>
What version of gRPC and what language are you using?
grpc-1.60.0-x86_64-linux, Ruby 3.3.0
What operating system (Linux, Windows,...) and version?
ubuntu-22.04-x64 running as part of a GitHub CI
What runtime / compiler are you using (e.g. python version or version of gcc)
Ruby/3.3.0/x64
What did you do?
Please provide either 1) A unit test for reproducing the bug or 2) Specific steps for us to follow to reproduce the bug. If there’s not enough information to debug the problem, gRPC team may close the issue at their discretion. You’re welcome to re-open the issue once you have a reproduction.
Inside Gemfile.lock, I am specifying platform specific versions of grpc as follows:
The GitHub CI is doing the following.
What did you expect to see?
bundle install
should be able to install and usegrpc-1.60.0-x86_64-linux
with the released version of Ruby 3.3.0.What did you see instead?
During
bundle install
, the following incompatibility is reported:See TROUBLESHOOTING.md for how to diagnose problems better.
Anything else we should know about your project / environment?
The app in question is running Rails 7.1.2.
The text was updated successfully, but these errors were encountered: