Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load default roots.pem in PHP via grpc_set_ssl_roots_override_callback #5711

Closed
jtattermusch opened this issue Mar 11, 2016 · 2 comments
Closed

Load default roots.pem in PHP via grpc_set_ssl_roots_override_callback #5711

jtattermusch opened this issue Mar 11, 2016 · 2 comments
Assignees
@stanley-cheung
Labels
area/security lang/php priority/P2
Milestone
2016/05/21 Milestone

Comments

@jtattermusch
Copy link
Contributor

This is required to not depend on user manually setting GRPC_DEFAULT_SSL_ROOTS_FILE_PATH env variable to get access to default roots. See #4834

C# implementation (for reference)
#5011
@jtattermusch jtattermusch added this to the GA milestone Mar 11, 2016
@jtattermusch
Copy link
Contributor Author

After this is implemented, the make install-certs should be removed:
https://github.com/grpc/grpc/blob/master/tools/dockerfile/grpc_interop_php/build_interop.sh#L43

@nicolasnoble nicolasnoble modified the milestones: GA, 2016/05/21 Milestone Apr 21, 2016
@thinkerou thinkerou mentioned this issue Jun 9, 2016
Merged
@stanley-cheung
Copy link
Contributor

Can close this?

@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@stanley-cheung stanley-cheung

Labels
area/security lang/php priority/P2
Projects
None yet
Milestone
2016/05/21 Milestone
Development

No branches or pull requests
4 participants
@nicolasnoble @jtattermusch @stanley-cheung @kpayson64