Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into possible hangs in Python's unit._rpc_test.RPCTest at tearDown w/o explicit server stop #8629

Closed
soltanmm-google opened this issue Nov 3, 2016 · 6 comments
Assignees
Milestone

Comments

@soltanmm-google
Copy link
Contributor

What it says on the tin. Remove the tearDown introduced by #8628, figure out what might or might not be flakily causing the tests to hang for an apparently finite (but long) time.

@soltanmm-google soltanmm-google self-assigned this Nov 3, 2016
@nathanielmanistaatgoogle nathanielmanistaatgoogle added this to the 1.1 milestone Nov 3, 2016
@nathanielmanistaatgoogle
Copy link
Member

Looking further: we should resume explicitly testing server-shutdown-on-garbage-collection-in-Python-interpreters-with-deterministic-garbage-collection with the thought that even though we'd like applications to never explicitly depend on the behavior we would want to have confidence that if they accidentally forgot to stop their server they'd likely have a better debugging experience.

@soltanmm-google
Copy link
Contributor Author

(specifically for CPython, where we think we understand the garbage collector's behavior)

@soltanmm-google
Copy link
Contributor Author

soltanmm-google commented Nov 16, 2016

Hangs still occur even with explicit stop, but oddly only with certain combinations of tests under unit._rpc_test running.

EDIT: I still haven't figured out what those combinations exactly are.

@soltanmm-google soltanmm-google added the disposition/BUILDNURSE For all buildnurse related build/test failures and flakes label Dec 16, 2016
@soltanmm-google
Copy link
Contributor Author

@nathanielmanistaatgoogle
Copy link
Member

Seen again in gRPC_master_macos build 1111.

ericgribkoff added a commit that referenced this issue Jan 12, 2017
Add HTTP/2 interop test client

Known failures: #8629
@nathanielmanistaatgoogle
Copy link
Member

Punting from 1.1; this fire just isn't burning hot enough.

Also removing the BUILDPONY label; this isn't actually about currently failing tests but rather is about investigating in the future making a potential modification to our tests and then observing whether and how they then begin to fail.

@nathanielmanistaatgoogle nathanielmanistaatgoogle removed the disposition/BUILDNURSE For all buildnurse related build/test failures and flakes label Jan 18, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Sep 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants