Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-1.0.1 Makefile simple issue breaks MSYS2 execution #8774

Closed
emmenlau opened this issue Nov 16, 2016 · 1 comment
Closed

grpc-1.0.1 Makefile simple issue breaks MSYS2 execution #8774

emmenlau opened this issue Nov 16, 2016 · 1 comment

Comments

@emmenlau
Copy link
Contributor

The Makefile of grpc-1.0.1 executes protoc with argument:

--plugin=protoc-gen-grpc=$(BINDIR)/$(CONFIG)/grpc_cpp_plugin

However when used on Windows with MSYS2, the correct name of grpc_cpp_plugin is grpc_cpp_plugin.exe. Without the exe-suffix, the plugin fails. With the exe-suffix, everything works as expected. Would it be possible to add a target-specific suffix for Windows?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants