QPS test that uses inproc transport #12362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
|
|
|
|
1 similar comment
|
guantaol
approved these changes
Sep 7, 2017
test/cpp/qps/server_async.cc
Outdated
| // Negative port number means inproc server, so no listen port needed | ||
| if (port_num >= 0) { | ||
| char *server_address = NULL; | ||
| gpr_join_host_port(&server_address, "::", port()); |
There was a problem hiding this comment.
Just use port_num?
gpr_join_host_port(&server_address, "::", port_num);
test/cpp/qps/server_sync.cc
Outdated
| // Negative port number means inproc server, so no listen port needed | ||
| if (port_num >= 0) { | ||
| char* server_address = NULL; | ||
| gpr_join_host_port(&server_address, "::", port()); |
There was a problem hiding this comment.
Just use port_num?
gpr_join_host_port(&server_address, "::", port_num);
|
|
|
I will not merge this until #12433 gets resolved |
|
Rebased master and mixed in #12797 hoping that that makes tests pass that were previously OOMing |
|
vjpai
force-pushed
the
inproc_qps
branch
2 times, most recently
from
0b0ab2f
to
d5da6db
Compare
|
Rebased and squashed now that #12797 is in. Diff unchanged. |
|
|
|
|
|
|
|
1 similar comment
|
|
1 similar comment
|
vjpai
force-pushed
the
inproc_qps
branch
2 times, most recently
from
19c0b27
to
d21ef70
Compare
|
1 similar comment
|
|
|
|
1 similar comment
|
…to standard testing suite.
|
|
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the goals of this is to help debug remaining issues with QPS testing