Add distribtest for using grpc as a pre-installed cmake package #12469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jtattermusch
force-pushed
the
cpp_distrib_cmake
branch
from
007f99a
to
5d2b1b3
Compare
|
|
mehrdada
reviewed
Sep 10, 2017
| @@ -27,4 +27,6 @@ RUN apt-get update && apt-get install -y \ | |||
| pkg-config \ | |||
| unzip && apt-get clean | |||
|
|
|||
| RUN apt-get update && apt-get install -y cmake golang && apt-get clean | |||
There was a problem hiding this comment.
I'm curious if golang from jessie is new enough or shall we fetch from golang.org tarballs and install that instead?
There was a problem hiding this comment.
the golang here is only to be able to build boringssl using cmake (they are using go to generate some code or config). It's not golang used by gRPC go (and I assume that's what you meant by 1.6 support going away soon).
mehrdada
approved these changes
Sep 10, 2017
jtattermusch
force-pushed
the
cpp_distrib_cmake
branch
from
5d2b1b3
to
ae6fd66
Compare
|
|
yang-g
approved these changes
Sep 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #12411.
Add add a distribtest that installs gRPC using cmake (with gRPC_XXX_PROVIDER=package) and then tests the helloworld example can be built using cmake.
Currently
make installis a better way to install gRPC on Linux, but allowing using cmake install might be useful for other platforms (Windows) and adding the distribtest also revealed some flaws in our CMakeLists.txt.Followup work:
-- setup cmake distribtests where grpc is used as a submodule.
-- decide what cmake use cases will be officially supported (grpc=submodule, grpc=package, ...)