Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip gRPC Python Protoc Plug-In default behavior #12625

Merged
merged 1 commit into from Sep 19, 2017
Merged

Flip gRPC Python Protoc Plug-In default behavior #12625

merged 1 commit into from Sep 19, 2017

Conversation

nathanielmanistaatgoogle
Copy link
Member

Whee!

@nathanielmanistaatgoogle
Flip gRPC Python Protoc Plug-In default behavior
2c1a7e1 
Now the grpc_2_0 flag is no longer required for the only-generate-code-
elements-in-_pb2_grpc.py-files behavior and the grpc_1_0 flag is
required for the add-generated-gRPC-using-code-elements-to-_pb2.py-
files behavior.
@grpc-kokoro
Copy link 

[trickle] No significant performance differences

@grpc-kokoro
Copy link 

Corrupt JSON data (indicates timeout or crash): 
    bm_fullstack_streaming_ping_pong.BM_StreamingPingPongWithCoalescingApi_MinInProcessCHTTP2_NoOpMutator_NoOpMutator__2M_2_0.opt.old: 1


[microbenchmarks] No significant performance differences

@nathanielmanistaatgoogle
Copy link
Member Author

Obstacles: issue 11737 and issue 12394.

@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit 574faf3 into grpc:master Sep 19, 2017
@yashykt yashykt mentioned this pull request Sep 21, 2017
Closed
@nathanielmanistaatgoogle nathanielmanistaatgoogle mentioned this pull request Oct 10, 2017
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mehrdada mehrdada mehrdada approved these changes

@kpayson64 kpayson64 kpayson64 approved these changes

Assignees
No one assigned
Labels
area/protoc plugins cla: yes lang/Python priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nathanielmanistaatgoogle @grpc-kokoro @mehrdada @kpayson64 @googlebot