Fix Xcode warning of mis-aligned structs #12772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2017
makdharma
approved these changes
Oct 4, 2017
|
Confirmed by author of nanopb that wire format is not affected. |
|
Test failures: |
muxi
added a commit
that referenced
this pull request
Oct 5, 2017
Backport #12772: Fix Xcode warning of mis-aligned structs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Xcode warning of struct misalignment is due to nanopb packing structs across byte alignment boundaries. It appears there is no Apple LLVM compiler option provided to supress this problem. On the other hand, nanopb supports disabling struct packing for compatibility on some platforms.
In this PR, we disable struct packing to eliminates the corresponding warning. The cost of the change, according to nanopb manual, should be minor RAM increase.
#12194