Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GPR review: Privatize useful.h and avl.h #14184

Merged
merged 10 commits into from
Feb 9, 2018
Merged

GPR review: Privatize useful.h and avl.h #14184

merged 10 commits into from
Feb 9, 2018

Conversation

vjpai
Copy link
Member

@vjpai vjpai commented Jan 25, 2018

These should not be public headers

@vjpai vjpai requested a review from yashykt January 25, 2018 21:35
@vjpai vjpai added this to Not yet started in De-wrapping of C++ via automation Jan 25, 2018
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

1 similar comment
@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  [ = ]       0 [None]     +16  +0.0%

  [ = ]       0 TOTAL      +16  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@vjpai
Copy link
Member Author

vjpai commented Jan 26, 2018

Will not merge until grpc/proposal#56 lands, which is Feb 8 at the earliest

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%    +128 [None]    +448  +0.0%

  +0.0%    +128 TOTAL     +448  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE              FILE SIZE
 ++++++++++++++ GROWIN ++++++++++++++
  +0.0%    +128 [None]    +456  +0.0%

  +0.0%    +128 TOTAL     +456  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                               FILE SIZE
 ++++++++++++++ GROWING                 ++++++++++++++
  [NEW] +2.43Ki src/core/lib/avl/avl.cc +2.43Ki  [NEW]
      [NEW]    +943 rebalance                  +943  [NEW]
      [NEW]    +517 remove_key                 +517  [NEW]
      [NEW]    +318 add_key                    +318  [NEW]
      [NEW]    +132 new_node                   +132  [NEW]
      [NEW]    +110 grpc_avl_maybe_get         +110  [NEW]
      [NEW]    +104 grpc_avl_get               +104  [NEW]
      [NEW]    +102 unref_node                 +102  [NEW]
      [NEW]     +89 [Unmapped]                  +89  [NEW]
      [NEW]     +58 grpc_avl_add                +58  [NEW]
      [NEW]     +58 grpc_avl_remove             +58  [NEW]
      [NEW]     +38 grpc_avl_ref                +38  [NEW]
      [NEW]      +9 grpc_avl_is_empty            +9  [NEW]
      [NEW]      +6 grpc_avl_create              +6  [NEW]
      [NEW]      +5 grpc_avl_unref               +5  [NEW]
  +0.0%    +160 [None]                     +536  +0.0%

 -------------- SHRINKING               --------------
  [DEL] -2.43Ki src/core/lib/gpr/avl.cc -2.43Ki  [DEL]
      [DEL]    -943 rebalance                  -943  [DEL]
      [DEL]    -517 remove_key                 -517  [DEL]
      [DEL]    -318 add_key                    -318  [DEL]
      [DEL]    -132 new_node                   -132  [DEL]
      [DEL]    -110 gpr_avl_maybe_get          -110  [DEL]
      [DEL]    -104 gpr_avl_get                -104  [DEL]
      [DEL]    -102 unref_node                 -102  [DEL]
      [DEL]     -89 [Unmapped]                  -89  [DEL]
      [DEL]     -58 gpr_avl_add                 -58  [DEL]
      [DEL]     -58 gpr_avl_remove              -58  [DEL]
      [DEL]     -38 gpr_avl_ref                 -38  [DEL]
      [DEL]      -9 gpr_avl_is_empty             -9  [DEL]
      [DEL]      -6 gpr_avl_create               -6  [DEL]
      [DEL]      -5 gpr_avl_unref                -5  [DEL]

  +0.0%    +160 TOTAL                      +536  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                               FILE SIZE
 ++++++++++++++ GROWING                 ++++++++++++++
  [NEW] +2.43Ki src/core/lib/avl/avl.cc +2.43Ki  [NEW]
      [NEW]    +943 rebalance                  +943  [NEW]
      [NEW]    +517 remove_key                 +517  [NEW]
      [NEW]    +318 add_key                    +318  [NEW]
      [NEW]    +132 new_node                   +132  [NEW]
      [NEW]    +110 grpc_avl_maybe_get         +110  [NEW]
      [NEW]    +104 grpc_avl_get               +104  [NEW]
      [NEW]    +102 unref_node                 +102  [NEW]
      [NEW]     +89 [Unmapped]                  +89  [NEW]
      [NEW]     +58 grpc_avl_add                +58  [NEW]
      [NEW]     +58 grpc_avl_remove             +58  [NEW]
      [NEW]     +38 grpc_avl_ref                +38  [NEW]
      [NEW]      +9 grpc_avl_is_empty            +9  [NEW]
      [NEW]      +6 grpc_avl_create              +6  [NEW]
      [NEW]      +5 grpc_avl_unref               +5  [NEW]
  +0.0%    +160 [None]                     +536  +0.0%

 -------------- SHRINKING               --------------
  [DEL] -2.43Ki src/core/lib/gpr/avl.cc -2.43Ki  [DEL]
      [DEL]    -943 rebalance                  -943  [DEL]
      [DEL]    -517 remove_key                 -517  [DEL]
      [DEL]    -318 add_key                    -318  [DEL]
      [DEL]    -132 new_node                   -132  [DEL]
      [DEL]    -110 gpr_avl_maybe_get          -110  [DEL]
      [DEL]    -104 gpr_avl_get                -104  [DEL]
      [DEL]    -102 unref_node                 -102  [DEL]
      [DEL]     -89 [Unmapped]                  -89  [DEL]
      [DEL]     -58 gpr_avl_add                 -58  [DEL]
      [DEL]     -58 gpr_avl_remove              -58  [DEL]
      [DEL]     -38 gpr_avl_ref                 -38  [DEL]
      [DEL]      -9 gpr_avl_is_empty             -9  [DEL]
      [DEL]      -6 gpr_avl_create               -6  [DEL]
      [DEL]      -5 gpr_avl_unref                -5  [DEL]

  +0.0%    +160 TOTAL                      +536  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                               FILE SIZE
 ++++++++++++++ GROWING                 ++++++++++++++
  [NEW] +2.43Ki src/core/lib/avl/avl.cc +2.43Ki  [NEW]
      [NEW]    +943 rebalance                  +943  [NEW]
      [NEW]    +517 remove_key                 +517  [NEW]
      [NEW]    +318 add_key                    +318  [NEW]
      [NEW]    +132 new_node                   +132  [NEW]
      [NEW]    +110 grpc_avl_maybe_get         +110  [NEW]
      [NEW]    +104 grpc_avl_get               +104  [NEW]
      [NEW]    +102 unref_node                 +102  [NEW]
      [NEW]     +89 [Unmapped]                  +89  [NEW]
      [NEW]     +58 grpc_avl_add                +58  [NEW]
      [NEW]     +58 grpc_avl_remove             +58  [NEW]
      [NEW]     +38 grpc_avl_ref                +38  [NEW]
      [NEW]      +9 grpc_avl_is_empty            +9  [NEW]
      [NEW]      +6 grpc_avl_create              +6  [NEW]
      [NEW]      +5 grpc_avl_unref               +5  [NEW]
  +0.0%    +160 [None]                     +536  +0.0%

 -------------- SHRINKING               --------------
  [DEL] -2.43Ki src/core/lib/gpr/avl.cc -2.43Ki  [DEL]
      [DEL]    -943 rebalance                  -943  [DEL]
      [DEL]    -517 remove_key                 -517  [DEL]
      [DEL]    -318 add_key                    -318  [DEL]
      [DEL]    -132 new_node                   -132  [DEL]
      [DEL]    -110 gpr_avl_maybe_get          -110  [DEL]
      [DEL]    -104 gpr_avl_get                -104  [DEL]
      [DEL]    -102 unref_node                 -102  [DEL]
      [DEL]     -89 [Unmapped]                  -89  [DEL]
      [DEL]     -58 gpr_avl_add                 -58  [DEL]
      [DEL]     -58 gpr_avl_remove              -58  [DEL]
      [DEL]     -38 gpr_avl_ref                 -38  [DEL]
      [DEL]      -9 gpr_avl_is_empty             -9  [DEL]
      [DEL]      -6 gpr_avl_create               -6  [DEL]
      [DEL]      -5 gpr_avl_unref                -5  [DEL]

  +0.0%    +160 TOTAL                      +536  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                               FILE SIZE
 ++++++++++++++ GROWING                 ++++++++++++++
  [NEW] +2.43Ki src/core/lib/avl/avl.cc +2.43Ki  [NEW]
      [NEW]    +943 rebalance                  +943  [NEW]
      [NEW]    +517 remove_key                 +517  [NEW]
      [NEW]    +318 add_key                    +318  [NEW]
      [NEW]    +132 new_node                   +132  [NEW]
      [NEW]    +110 grpc_avl_maybe_get         +110  [NEW]
      [NEW]    +104 grpc_avl_get               +104  [NEW]
      [NEW]    +102 unref_node                 +102  [NEW]
      [NEW]     +89 [Unmapped]                  +89  [NEW]
      [NEW]     +58 grpc_avl_add                +58  [NEW]
      [NEW]     +58 grpc_avl_remove             +58  [NEW]
      [NEW]     +38 grpc_avl_ref                +38  [NEW]
      [NEW]      +9 grpc_avl_is_empty            +9  [NEW]
      [NEW]      +6 grpc_avl_create              +6  [NEW]
      [NEW]      +5 grpc_avl_unref               +5  [NEW]
  +0.0%    +160 [None]                     +536  +0.0%

 -------------- SHRINKING               --------------
  [DEL] -2.43Ki src/core/lib/gpr/avl.cc -2.43Ki  [DEL]
      [DEL]    -943 rebalance                  -943  [DEL]
      [DEL]    -517 remove_key                 -517  [DEL]
      [DEL]    -318 add_key                    -318  [DEL]
      [DEL]    -132 new_node                   -132  [DEL]
      [DEL]    -110 gpr_avl_maybe_get          -110  [DEL]
      [DEL]    -104 gpr_avl_get                -104  [DEL]
      [DEL]    -102 unref_node                 -102  [DEL]
      [DEL]     -89 [Unmapped]                  -89  [DEL]
      [DEL]     -58 gpr_avl_add                 -58  [DEL]
      [DEL]     -58 gpr_avl_remove              -58  [DEL]
      [DEL]     -38 gpr_avl_ref                 -38  [DEL]
      [DEL]      -9 gpr_avl_is_empty             -9  [DEL]
      [DEL]      -6 gpr_avl_create               -6  [DEL]
      [DEL]      -5 gpr_avl_unref                -5  [DEL]

  +0.0%    +160 TOTAL                      +536  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

2 similar comments
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                               FILE SIZE
 ++++++++++++++ GROWING                 ++++++++++++++
  [NEW] +2.43Ki src/core/lib/avl/avl.cc +2.43Ki  [NEW]
      [NEW]    +943 rebalance                  +943  [NEW]
      [NEW]    +517 remove_key                 +517  [NEW]
      [NEW]    +318 add_key                    +318  [NEW]
      [NEW]    +132 new_node                   +132  [NEW]
      [NEW]    +110 grpc_avl_maybe_get         +110  [NEW]
      [NEW]    +104 grpc_avl_get               +104  [NEW]
      [NEW]    +102 unref_node                 +102  [NEW]
      [NEW]     +89 [Unmapped]                  +89  [NEW]
      [NEW]     +58 grpc_avl_add                +58  [NEW]
      [NEW]     +58 grpc_avl_remove             +58  [NEW]
      [NEW]     +38 grpc_avl_ref                +38  [NEW]
      [NEW]      +9 grpc_avl_is_empty            +9  [NEW]
      [NEW]      +6 grpc_avl_create              +6  [NEW]
      [NEW]      +5 grpc_avl_unref               +5  [NEW]
  +0.0%    +160 [None]                     +528  +0.0%

 -------------- SHRINKING               --------------
  [DEL] -2.43Ki src/core/lib/gpr/avl.cc -2.43Ki  [DEL]
      [DEL]    -943 rebalance                  -943  [DEL]
      [DEL]    -517 remove_key                 -517  [DEL]
      [DEL]    -318 add_key                    -318  [DEL]
      [DEL]    -132 new_node                   -132  [DEL]
      [DEL]    -110 gpr_avl_maybe_get          -110  [DEL]
      [DEL]    -104 gpr_avl_get                -104  [DEL]
      [DEL]    -102 unref_node                 -102  [DEL]
      [DEL]     -89 [Unmapped]                  -89  [DEL]
      [DEL]     -58 gpr_avl_add                 -58  [DEL]
      [DEL]     -58 gpr_avl_remove              -58  [DEL]
      [DEL]     -38 gpr_avl_ref                 -38  [DEL]
      [DEL]      -9 gpr_avl_is_empty             -9  [DEL]
      [DEL]      -6 gpr_avl_create               -6  [DEL]
      [DEL]      -5 gpr_avl_unref                -5  [DEL]

  +0.0%    +160 TOTAL                      +528  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE                               FILE SIZE
 ++++++++++++++ GROWING                 ++++++++++++++
  [NEW] +2.43Ki src/core/lib/avl/avl.cc +2.43Ki  [NEW]
      [NEW]    +943 rebalance                  +943  [NEW]
      [NEW]    +517 remove_key                 +517  [NEW]
      [NEW]    +318 add_key                    +318  [NEW]
      [NEW]    +132 new_node                   +132  [NEW]
      [NEW]    +110 grpc_avl_maybe_get         +110  [NEW]
      [NEW]    +104 grpc_avl_get               +104  [NEW]
      [NEW]    +102 unref_node                 +102  [NEW]
      [NEW]     +89 [Unmapped]                  +89  [NEW]
      [NEW]     +58 grpc_avl_add                +58  [NEW]
      [NEW]     +58 grpc_avl_remove             +58  [NEW]
      [NEW]     +38 grpc_avl_ref                +38  [NEW]
      [NEW]      +9 grpc_avl_is_empty            +9  [NEW]
      [NEW]      +6 grpc_avl_create              +6  [NEW]
      [NEW]      +5 grpc_avl_unref               +5  [NEW]
  +0.0%    +160 [None]                     +528  +0.0%

 -------------- SHRINKING               --------------
  [DEL] -2.43Ki src/core/lib/gpr/avl.cc -2.43Ki  [DEL]
      [DEL]    -943 rebalance                  -943  [DEL]
      [DEL]    -517 remove_key                 -517  [DEL]
      [DEL]    -318 add_key                    -318  [DEL]
      [DEL]    -132 new_node                   -132  [DEL]
      [DEL]    -110 gpr_avl_maybe_get          -110  [DEL]
      [DEL]    -104 gpr_avl_get                -104  [DEL]
      [DEL]    -102 unref_node                 -102  [DEL]
      [DEL]     -89 [Unmapped]                  -89  [DEL]
      [DEL]     -58 gpr_avl_add                 -58  [DEL]
      [DEL]     -58 gpr_avl_remove              -58  [DEL]
      [DEL]     -38 gpr_avl_ref                 -38  [DEL]
      [DEL]      -9 gpr_avl_is_empty             -9  [DEL]
      [DEL]      -6 gpr_avl_create               -6  [DEL]
      [DEL]      -5 gpr_avl_unref                -5  [DEL]

  +0.0%    +160 TOTAL                      +528  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@vjpai vjpai merged commit 063d5de into grpc:master Feb 9, 2018
De-wrapping of C++ automation moved this from In progress to Done Feb 9, 2018
@vjpai vjpai deleted the gpr_review branch February 9, 2018 01:27
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dgquintas dgquintas dgquintas approved these changes

@yashykt yashykt Awaiting requested review from yashykt

@a11r a11r Awaiting requested review from a11r

@markdroth markdroth Awaiting requested review from markdroth

Assignees
No one assigned
Labels
None yet
Projects
De-wrapping of C++
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vjpai @grpc-testing @dgquintas