Cancel max idle timer when shutting down the server channel

[y-zeng]

The max idle timer was not shutdown properly when the server channel is being shutdown. This caused a reference of each channel stack to be held until the max idle timer times out.

[grpc-testing]

****************************************************************

libgrpc.so

     VM SIZE                                                      FILE SIZE
 ++++++++++++++ GROWING                                        ++++++++++++++
  +0.0%      +8 [None]                                            +136  +0.0%
  +1.1%     +32 src/core/ext/filters/max_age/max_age_filter.cc     +32  +1.1%
       +25%     +40 channel_connectivity_changed                       +40   +25%

  +0.0%     +40 TOTAL                                             +168  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[grpc-testing]

[trickle] No significant performance differences

[grpc-testing]

[microbenchmarks] No significant performance differences

[abaldeva]

Fix looks good on my end. Thx!

I see that at least one of the automated build has failed but can't see the details. Any idea when this fix would become part of an official release? Would it be part of 1.9.2 or go to 1.10.0?

Thanks.

[y-zeng]

Looks like it's a testing issue. The test could not fetch the abseil submodule. I'll try it again.

[y-zeng]

I'll try to catch the 1.10.0 train.

[grpc-testing]

****************************************************************

libgrpc.so

     VM SIZE                                                      FILE SIZE
 ++++++++++++++ GROWING                                        ++++++++++++++
  +0.0%      +8 [None]                                            +128  +0.0%
  +1.1%     +32 src/core/ext/filters/max_age/max_age_filter.cc     +32  +1.1%
       +25%     +40 channel_connectivity_changed                       +40   +25%

  +0.0%     +40 TOTAL                                             +160  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[grpc-testing]

[trickle] No significant performance differences

[grpc-testing]

[microbenchmarks] No significant performance differences

[mehrdada]

Please merge this on 1.10.x first (edit the target branch on top of GitHub PR) and upmerge instead master-then-backport. It should be easy since everything on the 1.10.x branch is already upmerged, and it'll be a clean upmerge. Thanks!

UPDATE: I guess it needs a rebase locally and a push -f as the GitHub UI does not do that :(

[grpc-testing]

****************************************************************

libgrpc.so

     VM SIZE                                                      FILE SIZE
 ++++++++++++++ GROWING                                        ++++++++++++++
  +0.0%      +8 [None]                                            +136  +0.0%
  +1.1%     +32 src/core/ext/filters/max_age/max_age_filter.cc     +32  +1.1%
       +25%     +40 channel_connectivity_changed                       +40   +25%

  +0.0%     +40 TOTAL                                             +168  +0.0%


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

[grpc-testing]

[trickle] No significant performance differences

[grpc-testing]

[microbenchmarks] No significant performance differences