simplify CMake build #14885
Merged
simplify CMake build #14885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
reviewed
Apr 3, 2018
| libprotobuf | ||
| libgrpc++ | ||
| grpc++ | ||
| ${_gRPC_PROTOBUF_LIBRARIES} |
There was a problem hiding this comment.
nit: the gRPC_PROTOBUF_LIBRARIES is meant to be internal (hence the "" prefix), so I'd suggest just referring to "libprotobuf" explicitly here.
jtattermusch
approved these changes
Apr 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Android build file to no longer require manually specifying all of the third_party deps and just directly adds in the
grpc++target from the main repo's CMakeLists build.@jtattermusch Thanks for the suggestions on #14830.