Completion queue binding for new requests API change #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move completion queue binding for new requests to the new request request time, not server instantiation time.
…-the-stream Conflicts: src/cpp/server/server.cc
…thub.com:ctiller/grpc into churn-churn-churn-the-api-gently-down-the-stream
|
Green - we should probably announce before merging, but could you take a quick look? |
|
@nathanielmanistaatgoogle, @soltanmm - please look at Python changes @yang-g - please look at everything |
|
As with that other C core API change in the last week or two: LGTM but @soltanmm is actively working in the area right now and he must also review and approve. |
|
LGTM |
1 similar comment
|
LGTM |
…-the-stream Conflicts: test/cpp/end2end/async_end2end_test.cc
|
LGTM |
|
@soltanmm - thoughts? If possible I'd like to have this in Monday. |
|
Apologies for the delay - I've been in my own little Python world for a bit. LGTM. |
|
Such green. Wow. |
yang-g
added a commit
that referenced
this pull request
May 12, 2015
…y-down-the-stream Completion queue binding for new requests API change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move completion queue binding for new requests to the new request
request time, not server instantiation time.