Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RpcException.StatusCode property #15140

Merged
merged 1 commit into from Apr 21, 2018
Merged

Add RpcException.StatusCode property #15140

merged 1 commit into from Apr 21, 2018

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Apr 20, 2018

This is purely for convenience - using e.Status.StatusCode looks
clunky compared with e.StatusCode, and this is the property most
likely to be used for exception filtering etc.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

This is purely for convenience - using `e.Status.StatusCode` looks
clunky compared with `e.StatusCode`, and this is the property most
likely to be used for exception filtering etc.
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@jskeet
Copy link
Contributor Author

jskeet commented Apr 20, 2018

(CLA now signed.)

Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jskeet
Copy link
Contributor Author

jskeet commented Apr 21, 2018

@jtattermusch: Do I need to worry about the interop CI failures?

@mehrdada
Copy link
Member

@jskeet I checked the interop failures. No need to worry about them now. It's a known failure.

@jskeet
Copy link
Contributor Author

jskeet commented Apr 21, 2018

Looks like I can't merge anyway. It's been a while since I've sent a PR for a repo I don't have write access to :)

@mehrdada mehrdada merged commit 98a56a2 into grpc:master Apr 21, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants