New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RpcException.StatusCode property #15140
Conversation
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
This is purely for convenience - using `e.Status.StatusCode` looks clunky compared with `e.StatusCode`, and this is the property most likely to be used for exception filtering etc.
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
(CLA now signed.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jtattermusch: Do I need to worry about the interop CI failures? |
@jskeet I checked the interop failures. No need to worry about them now. It's a known failure. |
Looks like I can't merge anyway. It's been a while since I've sent a PR for a repo I don't have write access to :) |
This is purely for convenience - using
e.Status.StatusCode
looksclunky compared with
e.StatusCode
, and this is the property mostlikely to be used for exception filtering etc.