Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build grpcio-testing alongside Python artifact builds #15819

Merged
merged 4 commits into from Jun 20, 2018
Merged

Build grpcio-testing alongside Python artifact builds #15819

merged 4 commits into from Jun 20, 2018

Conversation

mehrdada
Copy link
Member

@mehrdada mehrdada commented Jun 20, 2018 •
edited

Fixes #14294

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

1 similar comment
@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@mehrdada
Copy link
Member Author

mehrdada commented Jun 20, 2018 •
edited

Distribtest ID: 3381eeca-f7c8-4eef-b202-84cf0d9f0905

kpayson64
kpayson64 reviewed Jun 20, 2018
View reviewed changes
test/distrib/python/test_packages.sh
fi

HEALTH_ARCHIVES=("$EXTERNAL_GIT_ROOT"/input_artifacts/grpcio-health-checking-[0-9]*.tar.gz)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we moving this out of the "binary" "source" checks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to do it on both binary/source. Those are source-only packages so it wouldn't matter for them anyway, but our users might install them alongside the binary grpcio vs source grpcio and that might be a slightly different environment, (and the test is cheap), so I'd rather run it on every case.

@mehrdada mehrdada merged commit 062f369 into v1.13.x Jun 20, 2018
@mehrdada mehrdada deleted the mmx-grpcio-testing-build branch June 20, 2018 21:41
@ghostwriternr ghostwriternr mentioned this pull request Jul 8, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kpayson64 kpayson64 kpayson64 approved these changes

@nathanielmanistaatgoogle nathanielmanistaatgoogle Awaiting requested review from nathanielmanistaatgoogle

Assignees

@nathanielmanistaatgoogle nathanielmanistaatgoogle

Labels
area/build area/packaging & distribution kind/enhancement lang/Python priority/P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mehrdada @grpc-testing @kpayson64 @nathanielmanistaatgoogle