Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TROUBLESHOOTING.md #15940

Merged
merged 4 commits into from Jul 9, 2018
Merged

Add TROUBLESHOOTING.md #15940

merged 4 commits into from Jul 9, 2018

Conversation

jtattermusch
Copy link
Contributor

No description provided.

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

ncteisen
ncteisen approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@ncteisen ncteisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea!! We can eliminate one round trip on the community mailing thread since asking for trace is usually the first thing that happens.

I have some ideas to build this doc out too

TROUBLESHOOTING.md Outdated

## GRPC_VERBOSITY

`GRPC_VERBOSITY` is used to set the minimum level of log messages printed by gRPC (supported values are `DEBUG`, `INFO` and `ERROR`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add: "If this environment variable is unset, only ERROR logs will be printed"

TROUBLESHOOTING.md Outdated
# Print info about invocations of low-level C core API.
# Note that trace logs of log level DEBUG won't be displayed
# as GRPC_VERBOSITY and GRPC_TRACE are 2 independent settings.
GRPC_TRACE=api ./helloworld_application_using_grpc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting trace w/o verbosity does not accomplish much, since all the tracers use the INFO level of printing.

To test this, I ran

GRPC_TRACE=all bins/opt/h2_full_test simple_request

And nothing was output

@grpc-testing
Copy link 

****************************************************************

libgrpc.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]


****************************************************************

libgrpc++.so

     VM SIZE        FILE SIZE
 ++++++++++++++  ++++++++++++++

  [ = ]       0        0  [ = ]

@grpc-testing
Copy link 

[trickle] No significant performance differences

@grpc-testing
Copy link 

[microbenchmarks] No significant performance differences

@jtattermusch jtattermusch merged commit a894702 into grpc:master Jul 9, 2018
carl-mastrangelo
carl-mastrangelo reviewed Jul 9, 2018
View reviewed changes
Copy link
Contributor

@carl-mastrangelo carl-mastrangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Jul 19, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Oct 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carl-mastrangelo carl-mastrangelo carl-mastrangelo left review comments

@ncteisen ncteisen ncteisen approved these changes

Assignees

@ncteisen ncteisen

@carl-mastrangelo carl-mastrangelo

Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtattermusch @grpc-testing @ncteisen @carl-mastrangelo