-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GetSpanFromServerContext() to public header. #15984
Conversation
Currently, consumers of this code need to do:
The first line looks okay, but the second line is a bit odd (e.g. no grpcpp/ prefix). Is the second one considered a public header? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Nobody said anything against having grpc_plugin.h within src/cpp when I had the PR reviewed, so I assumed that was ok. |
|
|
include/grpcpp/opencensus.h
Outdated
@@ -19,6 +19,8 @@ | |||
#ifndef GRPCPP_OPENCENSUS_H | |||
#define GRPCPP_OPENCENSUS_H | |||
|
|||
#include "opencensus/trace/span.h" | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because of issues including the Abseil dependence, let me recommend that there should be an explicit check that we're actually building with bazel. Something like:
#ifndef GRPC_BAZEL_BUILD
#error OpenCensus for gRPC is only supported when building with bazel
#endif
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
|
No idea what this "mergeable" business is. I was expecting the followup commit to become a "fixup" in the git rebase sense. |
|
|
|
|
GetSpanFromServerContext() comes from <grpcpp/opencensus.h> as of grpc/grpc#15984
GetSpanFromServerContext() comes from <grpcpp/opencensus.h> as of grpc/grpc#15984
Move GetSpanFromServerContext() to public header.