Added cancel_after_first_response test #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // A buffered pipe to which we never write any value acts as a writer that just hangs. | ||
| GRXBufferedPipe *requestsBuffer = [[GRXBufferedPipe alloc] init]; | ||
|
|
||
| __block bool receivedResponse = false; |
There was a problem hiding this comment.
s/bool/BOOL, s/false/NO
| - (void)testCancelAfterFirstResponseRPC { | ||
| __weak XCTestExpectation *expectation = [self expectationWithDescription:@"CancelAfterFirstResponse"]; | ||
|
|
||
| // A buffered pipe to which we never write any value acts as a writer that just hangs. |
There was a problem hiding this comment.
But you are writing some value! :) Instead, you can e.g. add a comment before calling cancel, saying explicitly that we don't tell the requestBuffer that we're done.
There was a problem hiding this comment.
That was some overzealous copying. I fixed it.
|
Is the policy now to wait for Travis, even if we know it shouldn't be affected, to see if there are flaky tests? |
|
I think that since we know the tests won't be affected by this change, you can cancel the tests and merge. |
jcanizales
added a commit
that referenced
this pull request
May 20, 2015
Added cancel_after_first_response test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.