Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging #17064

Merged
merged 16 commits into from
Nov 1, 2018
Merged

Fix logging #17064

merged 16 commits into from
Nov 1, 2018

Commits on Oct 31, 2018

  1. Add failing unit test

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    ff1c31f View commit details
    Browse the repository at this point in the history

  2. Revert "Configure module level loggers with basicConfig()" 

    This reverts commit a20e207.
    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    1e05d48 View commit details
    Browse the repository at this point in the history

  3. Add NullHandler to avoid warnings about no handler

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    839722a View commit details
    Browse the repository at this point in the history

  4. Add basicConfig handler to unit tests

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    240ca50 View commit details
    Browse the repository at this point in the history

  5. Add basicConfig handler to grpcio_testing

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    fb972c9 View commit details
    Browse the repository at this point in the history

  6. Fix various mind-numbing typos

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    4d086ef View commit details
    Browse the repository at this point in the history

  7. Add logging tests to tests.json

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    db1294d View commit details
    Browse the repository at this point in the history

  8. Format code

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    a3ffca1 View commit details
    Browse the repository at this point in the history

  9. Add test for 'No handlers could be found' problem

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    b7335f5 View commit details
    Browse the repository at this point in the history

  10. Pull out function to patch stderr

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    79d0424 View commit details
    Browse the repository at this point in the history

  11. Format code

    @gnossen
    gnossen committed Oct 31, 2018
    Configuration menu
    Copy the full SHA
    acc72c0 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2018

  1. Fix splat

    @gnossen
    gnossen committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    fec3765 View commit details
    Browse the repository at this point in the history

  2. Add explicit test that user can configure their own handler

    @gnossen
    gnossen committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    78eae49 View commit details
    Browse the repository at this point in the history

  3. Appease the yapf gods

    @gnossen
    gnossen committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    dc05e31 View commit details
    Browse the repository at this point in the history

  4. Isolate logging in all test cases

    @gnossen
    gnossen committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    cf624a9 View commit details
    Browse the repository at this point in the history

  5. Use custom assertions

    @gnossen
    gnossen committed Nov 1, 2018
    Configuration menu
    Copy the full SHA
    18cc5f5 View commit details
    Browse the repository at this point in the history