Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition into state CONNECTING when we start name resolution #18141

Merged
merged 1 commit into from Feb 22, 2019

Conversation

markdroth
Copy link
Member

@markdroth markdroth commented Feb 22, 2019

When the channel starts name resolution, it should transition into state CONNECTING. We were previously failing to do that and remaining in state IDLE until after the LB policy was created, which is incorrect.

@markdroth markdroth added the release notes: yes Indicates if PR needs to be in release notes label Feb 22, 2019
Copy link
Member

@yashykt yashykt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for move to connecting state on resolution

@markdroth
Copy link
Member Author

Known failures: #17927 #18142

@markdroth markdroth merged commit d7fe3b0 into grpc:master Feb 22, 2019
@markdroth markdroth deleted the resolver_connectivity_state branch February 22, 2019 23:15
@lock lock bot locked as resolved and limited conversation to collaborators Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants