Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grpc.Tools: support generated filename corner cases #18470

Merged
merged 3 commits into from Mar 22, 2019
Merged

Grpc.Tools: support generated filename corner cases #18470

merged 3 commits into from Mar 22, 2019

Commits on Mar 22, 2019

  1. C# tools: support generated filename corner cases 

    protoc and gRPC codegens differently treat non-ASCII letter
characters and symbols other than underscores when constructing
their respective output filenames for generated .cs files.
This change reproduces their respective behaviors exactly.

Fixes grpc#17661
    kkm committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    cbb70f5 View commit details
    Browse the repository at this point in the history

  2. fixup! C# tools: support generated filename corner cases

    kkm committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    50aed8d View commit details
    Browse the repository at this point in the history

  3. fixup! C# tools: support generated filename corner cases

    kkm committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    aa40424 View commit details
    Browse the repository at this point in the history