-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Debian packaging targeting unstable #1906
Conversation
Not quite Lintian-clean yet
- bumped the Standards-Version (no changes required) - shorted the package synopsis
- reenable tests - remove unnecessary boilerplate - enabled hardened build flags
debian/rules is GPL-2, but the rest is BSD, so there's no licensing issues
chttp2_fake_security_invoke_large_request_test is failing consistently and I don't know why yet
László is another DD who was independently working on packaging grpc, so he can pool his efforts here. Some build-deps were added when I was trying to build protobuf3 from third_party, but they're not needed
First cut of Debian packaging
Manually cherry-picked from gcsideal's pull request commit 02ba43d
Manual cherry pick from Laszlo's commit 8e8b191
These don't seem to need to be included, as upstream appears to be doing the right thing.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@googlebot everything is okay, don't worry. |
Just to be extra sure, I've already signed the CLA, please verify. |
Just one minor admin comment. Could you possibly split this into two PRs ?
|
Sorry, I didn't spot that I was assigned to this one. And thinking about it, wouldn't it be better to base that from the release-0_9 branch so to truly have a 0.9.1 release ? |
Okay so bear with me, I'm new to doing collaborative development in Git and using Github. So are you asking me to merge the release-0_9 into my debian/sid branch and then send a PR from my debian/sid branch into the one on grpc/grpc? And I presume that means I abandon this PR? |
I'm going to close this one since it's abandoned. |
Contributions from Laszlo Boszormenyi, who is the other Debian Developer who was independently working packaging gRPC.
Some cleanup, make rebuildable.
This is for #662