Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP extension segfault #19109

Merged
merged 1 commit into from May 26, 2019
Merged

Fix PHP extension segfault #19109

merged 1 commit into from May 26, 2019

Conversation

stanley-cheung
Copy link
Contributor

Attempt to fix #19089

@stanley-cheung stanley-cheung added lang/php release notes: yes Indicates if PR needs to be in release notes labels May 22, 2019
ZhouyihaiDing
ZhouyihaiDing approved these changes May 22, 2019
View reviewed changes
Copy link
Contributor

@ZhouyihaiDing ZhouyihaiDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanley-cheung
Copy link
Contributor Author

Interop failures:

  • FAILED: cloud_to_cloud:nodepurejs:java_server:server_streaming:tls
  • FAILED: build_docker_java

Unrelated to this PR

@stanley-cheung stanley-cheung merged commit e553590 into grpc:master May 26, 2019
@stanley-cheung stanley-cheung deleted the php-segfault branch May 26, 2019 22:29
@stanley-cheung stanley-cheung mentioned this pull request May 26, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ZhouyihaiDing ZhouyihaiDing ZhouyihaiDing approved these changes

Assignees
No one assigned
Labels
lang/php release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP: coredump by getenv () from /lib64/libc.so.6
2 participants
@stanley-cheung @ZhouyihaiDing