PHP: Allow dots in metadata keys #19232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
added
lang/php
release notes: yes
|
@stanley-cheung it would be nice to add test, feel free to push additional commits to this PR. |
stanley-cheung
force-pushed
the
php_dots_in_metadata_keys
branch
from
9270732
to
c43b77b
Compare
|
@jtattermusch Added tests. Thanks. |
stanley-cheung
approved these changes
Jun 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dot was added to the spec a while ago, but PHP didn't update the code to reflect that.
https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests