Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Delegating Channel #19316

Merged
merged 5 commits into from
Aug 2, 2019
Merged

Add Delegating Channel #19316

merged 5 commits into from
Aug 2, 2019

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Jun 11, 2019

DelegatingChannel is an experimental class that allows users to override and modify the behavior of the channel.

Currently, only GetState, NotifyOnStateChangeImpl and WaitForStateChangeImpl can be overriden.

@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Jun 11, 2019
@yashykt yashykt requested a review from vjpai June 11, 2019 22:20
@vjpai
Copy link
Member

vjpai commented Aug 2, 2019

I assume that you need to change the above in the PR description if DelegatingChannel is now an experimental API class/

@yashykt yashykt added release notes: yes Indicates if PR needs to be in release notes lang/core and removed release notes: no Indicates if PR should not be in release notes labels Aug 2, 2019
@yashykt
Copy link
Member Author

yashykt commented Aug 2, 2019

Known Issues -
C/C++ MacOS - #19819
Node MacOS - #19422
Python Windows - #19170
Interop Cloud-to-Prod - #19834

@yashykt
Copy link
Member Author

yashykt commented Aug 2, 2019

Thanks for reviewing!

@yashykt yashykt merged commit e6756a5 into grpc:master Aug 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2019
@yashykt yashykt deleted the delegating_channel branch May 18, 2023 20:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants