Sched combiner closures instead of running to avoid data races #19531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
added
the
release notes: no
yang-g
approved these changes
Jul 10, 2019
This was referenced Sep 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change similar to #18491.
GRPC_CLOSURE_RUN runs the closure immediately. In our case, if we do that, we can end up with a use-after-free kind of bug, since we need to reference some elements in the op structure even after scheduling the closure.
By scheduling instead of running, we guarantee that the closures will not be run before we are done using the struct since we are using a combiner.
Fixes internal bug - b/132890439