Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catch the error if socket initialization fails #19766

Merged
merged 1 commit into from
Aug 26, 2019
Merged

catch the error if socket initialization fails #19766

merged 1 commit into from
Aug 26, 2019

Conversation

levpachmanov
Copy link

The error returned from grpc_custom_socket_vtable->init(socket, family); was ignored, causing the program to crash if the socket couldn't be initialized.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@jiangtaoli2016 jiangtaoli2016 merged commit 65233f7 into grpc:master Aug 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/core area/security lang/core release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants