Define Ruby Struct classes under GRPC::Core::

[blowmage]

It looks like the intention was to define these classes under GRPC::Core::, but they are currently being defined under Struct:: (which is the default for rb_struct_define).

If you want this change to be 100% backwards compatible, we can also add the following aliases:

Struct:: BatchResult  = GRPC::Core:: BatchResult
Struct:: NewServerRpc = GRPC::Core:: NewServerRpc
Struct:: Status       = GRPC::Core:: Status

[apolcyn]

I don't think changing the Status module will work for backwards compatibility reasons. Note that while NewServerRpc and BatchResult are relatively internal objects, Struct::Status is a part of the public surface API.

Can we solve the problem in #19893 (comment) by just moving the definition of Status out of the C extension?

[blowmage]

What about moving the definition and then aliasing the old name to the new name?

[apolcyn]

Though this would work, it's a slight complication - what's the motivation?

[blowmage]

The motivation is only that it looks like the intention would have been to locate these classes in the GRPC namespace instead of using the default location under Struct.

In Ruby I would expect an anonymous struct to be assigned to a constant:

GRPC::Core::Status = Struct.new(:code, :details, :metadata)

Instead of creating a named struct that uses the default location:

Struct.new('Status', :code, :details, :metadata) # Struct::Status

[blowmage]

I am happy to put this on pause and revisit it again once #19939 has been considered.

[apolcyn]

Noting this is a "release blocker" to make sure that the comment in #19893 (comment) is resolved before 1.24

(this isn't a 1.23 release blocker)

[blowmage]

FWIW, I think #19939 would be the release blocker, not this change.

[stale]

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 180 days. It will be closed automatically if no further update occurs in 1 day. Thank you for your contributions!