Remove call from queued picks when failing it due to channel destruction #20128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the repro of a SEGV seen in an internal stress test
For background, the test involves a few hundred grpclb/DNS channels. Here's the bottom of the log of a crash: https://gist.github.com/apolcyn/c30716d9b03d5414be0b463f3d66cf1c. gdb showed a nullptr access on
pending_batches_[0].batch
on this line, with SetPickerInDataPlane in the stack trace. It also showed that this happened after the call's channel'sdisconnect_error_
had already been set.