Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Bazel 0.29 (including Windows RBE) #20165

Merged
merged 3 commits into from
Sep 5, 2019
Merged

Upgrade to Bazel 0.29 (including Windows RBE) #20165

merged 3 commits into from
Sep 5, 2019

Conversation

jtattermusch
Copy link
Contributor

@jtattermusch jtattermusch commented Sep 4, 2019 •
edited
Loading

All bazel / bazel RBE builds should now be using bazel 0.29

@jtattermusch
Copy link
Contributor Author 

T:\src\github\grpc>bazel --bazelrc=tools/remote_build/windows.bazelrc build --invocation_id="06b052ff-8979-45e4-a069-fd9e583f780b" --workspace_status_command=tools/remote_build/workspace_status_kokoro.sh :all --incompatible_disallow_filetype=false --google_credentials=T:\src\gfile/rbe-windows-credentials.json
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
ERROR: Unrecognized option: --incompatible_disallow_filetype=false

@jtattermusch jtattermusch changed the title Windows bazel rbe 0.29 Upgrade to Bazel 0.29 (including Windows RBE) Sep 4, 2019
@jtattermusch jtattermusch mentioned this pull request Sep 4, 2019
Closed
@jtattermusch jtattermusch added lang/c++ release notes: yes Indicates if PR needs to be in release notes labels Sep 4, 2019
@jtattermusch
Copy link
Contributor Author

Known failures:
#20095

gnossen
gnossen approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@gnossen gnossen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: It would be nice if we could just update a single file for updates like this. Not necessary for this PR though.

@jtattermusch
Copy link
Contributor Author

Nit: It would be nice if we could just update a single file for updates like this. Not necessary for this PR though.

I'd like that to but so far I haven't come up with a good way of achieving that (one that would feel natural and wouldn't bring too much complexity)

@jtattermusch jtattermusch merged commit 1c319d7 into grpc:master Sep 5, 2019
This was referenced Sep 6, 2019
Merged
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gnossen gnossen gnossen approved these changes

@apolcyn apolcyn apolcyn approved these changes

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

Assignees

@gnossen gnossen

@apolcyn apolcyn

Labels
lang/c++ release notes: yes Indicates if PR needs to be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtattermusch @gnossen @apolcyn