Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20351

Merged
merged 1 commit into from
Sep 25, 2019
Merged

Fix #20351

merged 1 commit into from
Sep 25, 2019

Conversation

hcaseyal
Copy link
Contributor

@hcaseyal hcaseyal commented Sep 24, 2019

It doesn't make sense to check if an address is null here.

@hcaseyal hcaseyal added the release notes: no Indicates if PR should not be in release notes label Sep 24, 2019
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/core/lib/surface/server.cc Outdated Show resolved Hide resolved
src/core/lib/surface/server.cc Outdated Show resolved Hide resolved
@hcaseyal hcaseyal force-pushed the fix_server branch 2 times, most recently from 7a7c78d to 7b44e6b Compare September 24, 2019 20:56
Copy link
Contributor

@veblush veblush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@veblush veblush merged commit af26dfd into grpc:master Sep 25, 2019
@veblush veblush mentioned this pull request Sep 25, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants