Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21966
In short,
virtualenv >= 20.0.0
+realpath
doesn't work.virtualenv
introduces a breaking change in their20.0.x
release, where the Python binary changed from a script to a symlink. Our infrastructure code depended on previous behavior, and invokesrealpath
on the Python binary to get the full file path. However, for symlinks,realpath
always traces down the symlinks and eventually gets the system version of Python. Then, the build script installed gRPC Python packages in the wrong Python environment, resulted in test failure.Manual sanity check passed: