Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue 20928 #21981

Merged
merged 5 commits into from
Feb 13, 2020
Merged

Fix Issue 20928 #21981

merged 5 commits into from
Feb 13, 2020

Conversation

yashykt
Copy link
Member

@yashykt yashykt commented Feb 11, 2020 •
edited by markdroth

Fixes #20928

@yashykt yashykt added the release notes: no Indicates if PR should not be in release notes label Feb 11, 2020
markdroth
markdroth approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address comments before merging. Thanks!

src/core/ext/filters/client_channel/xds/xds_client.cc Outdated Show resolved Hide resolved
src/core/ext/filters/client_channel/xds/xds_client.cc Outdated Show resolved Hide resolved
src/core/ext/filters/client_channel/xds/xds_client.cc Outdated Show resolved Hide resolved
markdroth
markdroth reviewed Feb 13, 2020
View reviewed changes
src/core/ext/filters/client_channel/xds/xds_client.cc Outdated
@@ -1746,13 +1746,24 @@ XdsClient::XdsClient(Combiner* combiner, grpc_pollset_set* interested_parties,
}
}

XdsClient::~XdsClient() { GRPC_COMBINER_UNREF(combiner_, "xds_client"); }
XdsClient::~XdsClient() {
gpr_log(GPR_INFO, "[xds_client %p] Destroying xds client", this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please guard this by checking whether the tracer is enabled.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, alternatively, just remove this line for now, and wait for me to add it as part of #21941. :)

markdroth
markdroth approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@markdroth markdroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, aside from the one remaining comment. Thanks!

@yashykt
Copy link
Member Author

yashykt commented Feb 13, 2020

Known issues : #20792, #21675

@yashykt
Copy link
Member Author

yashykt commented Feb 13, 2020

Thanks for reviewing!

@yashykt yashykt merged commit 660e536 into grpc:master Feb 13, 2020
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
@yashykt yashykt deleted the 20928fix branch May 18, 2023 20:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@markdroth markdroth markdroth approved these changes

Assignees
No one assigned
Labels
release notes: no Indicates if PR should not be in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XdsTest/DropTest.Update/FakeResolver WARNING: ThreadSanitizer: use of an invalid mutex
2 participants
@yashykt @markdroth