New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds: send no-overprovisioning client capability and populate user_agent fields #22147
xds: send no-overprovisioning client capability and populate user_agent fields #22147
Conversation
CreateDiscoveryRequest(arena.ptr(), kLdsTypeUrl, version, nonce, error); | ||
// Populate node. | ||
if (populate_node) { | ||
envoy_api_v2_core_Node* node_msg = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggesting passing request into PopulateNode and move
envoy_api_v2_core_Node* node_msg =
envoy_api_v2_DiscoveryRequest_mutable_node(request, arena.ptr());
into PopulateNode in all 4 places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about that, but it won't work, because in XdsApi::CreateLrsInitialRequest()
, the outer message is a LoadStatsRequest
instead of a DiscoveryRequest
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on build changes.
Cherrypick #22147: xds: send no-overprovisioning client capability and populate user_agent fields
This changes the xds client to send the new client capability introduced to xds in envoyproxy/envoy#10136. We also now populate the new
user_agent_name
anduser_agent_version
fields.This change is a bit bloated, because it required updating the
envoy-api
,protoc-gen-validate
, andudpa
submodules and regenerating all of the upb codegen files. The only substantive changes are in the following files: