Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php extension: do not link rt in osx #2222

Merged
merged 2 commits into from Jun 25, 2015
Merged

php extension: do not link rt in osx #2222

merged 2 commits into from Jun 25, 2015

Conversation

stanley-cheung
Copy link
Contributor

@stanley-cheung stanley-cheung self-assigned this Jun 25, 2015
@stanley-cheung stanley-cheung added this to the Beta milestone Jun 25, 2015
@stanley-cheung
Copy link
Contributor Author

Notes:

  • if test $host ne *"darwin"*; then works in osx but not linux
  • if test $host != *"darwin"*; then works in linux but not osx
  • case statement seems to work in both

murgatroid99 added a commit that referenced this pull request Jun 25, 2015
@murgatroid99
Merge pull request #2222 from stanley-cheung/fix_php_extension_osx_co…
d42ad96 
…nfigure

php extension: do not link rt in osx
@murgatroid99 murgatroid99 merged commit d42ad96 into grpc:master Jun 25, 2015
@stanley-cheung stanley-cheung mentioned this pull request Jun 25, 2015
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@stanley-cheung stanley-cheung

Labels
lang/all wrapped languages lang/php
Projects
None yet
Milestone
Beta
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stanley-cheung @murgatroid99 @googlebot