backport PHP script cleanup fixes to 0.9 branch #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@murgatroid99 Michael, can you please review/approve this? Basically just the backport of #2203 to the 0.9 release branch. Only changes were to the scripts. Thanks. |
murgatroid99
added a commit
that referenced
this pull request
Jun 29, 2015
…anup backport PHP script cleanup fixes to 0.9 branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default_extension_dir=$(php -i | grep extension_dir | sed 's/.*=> //g')isn't safe. Decided to might as well backport php: refactor and cleanup some scripts #2203 back to the 0.9 branch