Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit conversion of size_t to int in proto_utils.h causes conversion warnings #22557

Closed

Conversation

bkietz
Copy link

@bkietz bkietz commented Apr 2, 2020

#21827 switched from using the deprecated int MessageLite::ByteSize() to size_t MessageLite::ByteSizeLong(), but the variable this call is assigned to was left as int. This causes conversion warnings (when these are enabled) and even build failures (with -Werror, for example) in projects which #include this header.

Added an explicit to int.

@nicolasnoble

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 2, 2020

CLA Check
The committers are authorized under a signed CLA.

@bkietz
Copy link
Author

bkietz commented Apr 7, 2020

@nicolasnoble I believe this doesn't warrant release notes but in any case I don't have the ability to add the labels required by Mergeable

@stale
Copy link

stale bot commented May 7, 2020

This issue/PR has been automatically marked as stale because it has not had any update (including commits, comments, labels, milestones, etc) for 30 days. It will be closed automatically if no further update occurs in 7 day. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant