Implicit conversion of size_t to int in proto_utils.h causes conversion warnings #22557
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#21827 switched from using the deprecated
int MessageLite::ByteSize()
tosize_t MessageLite::ByteSizeLong()
, but the variable this call is assigned to was left asint
. This causes conversion warnings (when these are enabled) and even build failures (with-Werror
, for example) in projects which#include
this header.Added an explicit to
int
.@nicolasnoble