Do not cancel RPC if send metadata size if larger than peer's limit #23806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashykt
added
the
release notes: no
yashykt
changed the title
yashykt
added
lang/core
release notes: yes
karthikravis
approved these changes
Aug 14, 2020
yashykt
requested review from
apolcyn,
jtattermusch,
markdroth and
nicolasnoble
as code owners
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This setting is advisory in nature and the peer might or might not enforce this limit. Additionally, since gRPC does not expose this peer limit back to the application, the application can not take an informed decision either on whether some metadata should be omitted. Given this nature of the arg, it makes sense to not enforce this setting on the send side, and leave it upto the receive side to choose to enforce it.
Refer - https://tools.ietf.org/html/rfc7540#section-10.5.1