Makefile: only support building deps from submodule #23957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtattermusch
force-pushed
the
makefile_more_cleanup
branch
from
35add67
to
5364576
Compare
jtattermusch
added
release notes: yes
|
@veblush this is now close to being ready for review - it's worth taking a first glance. |
veblush
approved these changes
Aug 27, 2020
jtattermusch
force-pushed
the
makefile_more_cleanup
branch
from
5364576
to
f62e220
Compare
|
Rebased. I will only merge once the release branch has been successfully cut. |
|
This seems safe to merge - feel free to revert if problems arise. |
stanhu
added a commit
to stanhu/grpc
that referenced
this pull request
Oct 30, 2021
grpc#23957 removed the ability to build against the system OpenSSL libraries. However, BoringSSL is not supported on such platforms as the IBM s390x. This commits restores the behavior of that merge request just for OpenSSL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as Makefile is now only intended for internal use, it doesn't make sense to support building from system-installed dependencies.
When building artifacts (which is now the primary purpose of Makefile), we are always building the dependencies from submodules (zlib being the only exception), so it doesn't make sense to keep all the complex Makefile machinery that tries to detect if dependencies are installed on the system etc. (e.g. the
..._CHECK_CMD,HAS_SYSTEM_...etc.)The result:
If this works out, the Makefile can be simplified even further in followup steps.